Skip to content

Fix image_version workflow trigger name #41267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2025
Merged

Fix image_version workflow trigger name #41267

merged 2 commits into from
Nov 17, 2025
+1 −1

Conversation

@rhysd
Copy link
Contributor

@rhysd rhysd commented Nov 15, 2025 •
edited
Loading

Why:

Closes: #41266

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fixed the trigger name. image_version is correct.

https://github.com/actions/runner/blob/b3a60e6b0630a15b2daa549429b9ae2cf19f4400/src/Sdk/WorkflowParser/workflow-v1.0.json#L322

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Copilot AI review requested due to automatic review settings November 15, 2025 10:50
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025 •
edited
Loading

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/reference/workflows-and-actions/events-that-trigger-workflows.md fpt
ghec
ghes@ 3.18 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.18 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 15, 2025
Copilot finished reviewing on behalf of rhysd November 15, 2025 10:52
Copilot AI reviewed Nov 15, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an incorrect workflow trigger name in the GitHub Actions documentation. The heading was incorrectly named image_version_ready without backticks, when it should be `image_version` to match both the actual event name used in workflow YAML and the formatting convention used for all other event headings in the document.

Key Changes

  • Corrected the event name from image_version_ready to image_version to match the workflow syntax shown in the code example
  • Added backticks around the event name to follow the established formatting pattern used for all other event headings in the document

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sharra-writes
Copy link
Contributor

Sharra-writes commented Nov 17, 2025

@rhysd Copilot agrees, and since this is a small change I'm going to accept it on the theory that if it's actually wrong, someone will come let me know pretty quickly.

@Sharra-writes Sharra-writes added this pull request to the merge queue Nov 17, 2025
Merged via the queue into github:main with commit 4f49e3b Nov 17, 2025
41 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Sharra-writes Sharra-writes Sharra-writes approved these changes

Assignees

No one assigned

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trigger name of new image version creation event is inconsistent

2 participants

@rhysd @Sharra-writes